Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't press Space in function breakpoint input #44555

Closed
joaomoreno opened this issue Feb 27, 2018 · 4 comments
Closed

Can't press Space in function breakpoint input #44555

joaomoreno opened this issue Feb 27, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Feb 27, 2018

Testing #43836

Space doesn't do anything. Probably, the list is eating it with the list.toggleExpand command, although the condition for that command is listFocus && !inputFocus. Works fine in the watch list.

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

Uff this is very tricky. I put a breakpoint in the inputFocus context key and it is correctly set to true.

Watch expresions is different in how it usses the input box, every time I render the element I recreate the input box. While in the breakpoints list I always reuse the input box via the templates.

Might you have a tip on how to debug this and who else could be stealing the key?

@joaomoreno
Copy link
Member Author

Sure man. Write it down in a post-it: abstractKeybindingService.js#85.

image

@joaomoreno
Copy link
Member Author

Also don't forget Developer: Inspect Context Keys.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 27, 2018
@isidorn isidorn added this to the February 2018 milestone Feb 27, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

@joaomoreno awesome thanks!
I remembered your inspect context keys, but in this case was not nice to use since the focus lost closes the input.

@bpasero bpasero added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants