Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore focus to last workbench component that had focus after closing quick pick #44722

Closed
warpdesign opened this issue Feb 28, 2018 · 3 comments
Closed

Restore focus to last workbench component that had focus after closing quick pick #44722

warpdesign opened this issue Feb 28, 2018 · 3 comments
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality quick-pick Quick-pick widget issues

Comments

@warpdesign
Copy link
Contributor

Steps to Reproduce:

  1. Open a new terminal and activate (focus) it
  2. Press ctrl+shift+p to open the palette menu
  3. Press Esc to close the palette

The focus is given to the editor instead of the terminal which previously got the focus.

This happens on Windows 10 and the latest insider build:

Version 1.21.0-insider
Commit 3fec610
Date 2018-02-28T05:17:16.839Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
@vscodebot
Copy link

vscodebot bot commented Feb 28, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Feb 28, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2018

This is the case for the whole workbench, not just the terminal.

@Tyriar Tyriar added workbench and removed terminal Integrated terminal issues labels Feb 28, 2018
@Tyriar Tyriar assigned bpasero and unassigned Tyriar Feb 28, 2018
@Tyriar Tyriar changed the title Terminal doesn't regain focus after palette is closed Previously focused workbench component doesn't regain focus after palette is closed Feb 28, 2018
@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues and removed workbench labels Feb 28, 2018
@bpasero bpasero removed their assignment Feb 28, 2018
@bpasero bpasero changed the title Previously focused workbench component doesn't regain focus after palette is closed Restore focus to last workbench component that had focus after closing quick pick Feb 28, 2018
@bpasero bpasero mentioned this issue Jun 30, 2018
Closed
This was referenced Aug 23, 2019
Closed
Closed
Closed
@bpasero bpasero added the *as-designed Described behavior is as designed label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@warpdesign @bpasero @Tyriar