Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive comment string matching #44998

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

oriash93
Copy link
Contributor

@oriash93 oriash93 commented Mar 4, 2018

resolves #35589

@alexdima
Copy link
Member

alexdima commented Mar 5, 2018

@oriash93 I don't know if this is true for all programming languages... But not a lot of programming languages use ASCII for comments either, so it might just work...

@oriash93
Copy link
Contributor Author

oriash93 commented Mar 6, 2018

@alexandrudima Here is a comparison of comments in some programming languages..
As you can see, some do contain alphabetic characters. Are they relevant to vscode? If these cases worth considering a different solution, let me know.

@alexdima alexdima added this to the March 2018 milestone Mar 18, 2018
@alexdima alexdima merged commit 939ae9e into microsoft:master Mar 26, 2018
@oriash93 oriash93 deleted the oriash93/35589 branch April 8, 2018 19:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support case-insensitive comment tokens
2 participants