Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom HTML tag confused by P #45082

Closed
smlombardi opened this issue Mar 5, 2018 · 3 comments
Closed

Custom HTML tag confused by P #45082

smlombardi opened this issue Mar 5, 2018 · 3 comments
Assignees
Labels
html HTML support issues

Comments

@smlombardi
Copy link

Issue Type: Bug

When using an Angular component they often use a custom HTML tag.

Prime NG, for example, uses <p-table> for their table component.

However, probably because of the opening p, the entire tag is not scoped as a tag: the -table part is mistakenly scoped as meta.tag.block.any.html entity.other.attribute-name.html

screen shot 2018-03-05 at 2 56 10 pm

<p-table [value]="people">
  <ng-template pTemplate="header">
    <tr>
      <th>First Name</th>
      <th>Last Name</th>
      <th>Sales</th>

    </tr>
  </ng-template>
  <ng-template pTemplate="body"
               let-person>
    <tr>
      <td>{{person.firstName}}</td>
      <td>{{person.lastName}}</td>
      <td>{{person.gross_sales}}</td>

    </tr>
  </ng-template>
</p-table>

VS Code version: Code - Insiders 1.21.0-insider (b76a4a7, 2018-03-02T11:50:18.388Z)
OS version: Darwin x64 17.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.28GB free)
Process Argv /Users/st016lo/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron
Screen Reader no
VM 0%
Extensions (27)
Extension Author (truncated) Version
vsc-material-theme Equ 1.4.2
code-settings-sync Sha 2.9.0
sort-lines Tyr 1.4.1
html-snippets abu 0.2.1
Bookmarks ale 0.18.1
project-manager ale 0.24.0
vscode-eslint dba 1.4.7
tslint eg2 1.0.28
prettier-vscode esb 1.2.2
vscode-console-wrapper fab 0.4.0
auto-rename-tag for 0.0.15
path-autocomplete ion 1.8.1
vscode-text-pastry jkj 1.2.0
svg joc 0.0.9
Angular2 joh 2.14.0
vscode-icon-theme jtl 1.6.1
ecdc mit 0.11.0
HTMLHint mka 0.4.0
vscode-scss mrm 0.6.2
vscode-stylefmt mrm 2.5.0
angular2-inline nat 0.0.17
vscode-versionlens pfl 0.19.1
polacode pnp 0.2.2
stylelint shi 0.33.0
Align ste 0.2.0
bootstrap4-vscode the 4.0.0
change-case wma 1.0.0

(2 theme extensions excluded)

@vscodebot vscodebot bot added the insiders label Mar 5, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 5, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@kieferrm
Copy link
Member

kieferrm commented Mar 6, 2018

Confirmed. This seems to be a problem in the html grammar. It only happens with pleft of the dash.

@aeschli
Copy link
Contributor

aeschli commented Mar 6, 2018

This issue was moved to textmate/html.tmbundle#79

@aeschli aeschli closed this as completed Mar 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
html HTML support issues
Projects
None yet
Development

No branches or pull requests

3 participants