Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta-shift-F should revert to find-only after activating meta-shift-H (find/replace) #45148

Closed
vesper8 opened this issue Mar 6, 2018 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search-replace Search and replace issues verified Verification succeeded
Milestone

Comments

@vesper8
Copy link

vesper8 commented Mar 6, 2018

Currently if you hit the shortcut for "Find in Files" it brings up the correct panel

If you hit the shortcut for "Replace in Files" it brings up the correct panel with both the find and the replace field

But if the Replace in Files panel is showing, and you use the "Find in Files" short cut, it doesn't bring up the correct "Find in Files" panel, instead it keeps the "Replace in Files" panel. The only way to go back to the "Find in Files" panel is to first close the side panel (Meta-B) and then activate the "Find in Files" shortcut again

The reason this is an issue is because when the Replace in Files panel is active, it will show you the split-page "Replace Preview"

And when going from Find in Files to Replace in Files back to Find in Files.. the expected behaviour is that it's only helping you FIND in files, instead it ends up showing you the Replace Preview which is not desired

@vscodebot vscodebot bot added editor editor-find Editor find operations labels Mar 6, 2018
@kieferrm kieferrm added search-replace Search and replace issues and removed editor editor-find Editor find operations labels Mar 8, 2018
@roblourens roblourens added the feature-request Request for new features or functionality label Mar 8, 2018
@roblourens roblourens added this to the March 2018 milestone Mar 8, 2018
@roblourens roblourens modified the milestones: March 2018, April 2018 Mar 26, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Apr 5, 2018
@sandy081 sandy081 added the verified Verification succeeded label Apr 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search-replace Search and replace issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants