Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow preLaunch task for compound list #45676

Closed
guidobouman opened this issue Mar 13, 2018 · 4 comments
Closed

Allow preLaunch task for compound list #45676

guidobouman opened this issue Mar 13, 2018 · 4 comments
Assignees
@isidorn @alexr00
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Milestone
October 2019

Comments

@guidobouman
Copy link

guidobouman commented Mar 13, 2018 •
edited

Issue Type: Feature Request

Currently we can add a preLaunchTask prop to any launch setting. This works well when running a single project. But this get unworkable when using compounds.

When running multiple projects (website, API & CMS for example) in a compound launch task, triggering a build task from each preLaunchTask can throw an error about files being in use during buildtime. This happens when a buildable dependency is referenced from more than one project.

Can we allow compounds to have a preLaunchTask as well? Then we can trigger a global build and run all of the projects after the single build has succeeded. Much like the start command in Visual Studio on Windows works right now.

VS Code version: Code 1.21.0 (9a199d7, 2018-03-07T10:54:22.798Z)
OS version: Darwin x64 17.4.0
@vscodebot vscodebot bot added the tasks Task system issues label Mar 13, 2018
@dbaeumer dbaeumer added debug Debug viewlet, configurations, breakpoints, adapter issues and removed tasks Task system issues labels Mar 14, 2018
@dbaeumer dbaeumer assigned isidorn and unassigned dbaeumer Mar 14, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 14, 2018 •
edited

This is a fair feature request. Not on our plan atm.
fyi @weinand

@isidorn isidorn added the feature-request Request for new features or functionality label Mar 14, 2018
@isidorn isidorn added this to the Backlog milestone Mar 14, 2018
@isidorn isidorn removed their assignment Mar 14, 2018
@isidorn isidorn self-assigned this Oct 8, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 8, 2019

This should be possible now that @alexr00 added global tasks.
So adding to this milestone so @alexr00 and me look into if something is missing here

@isidorn isidorn modified the milestones: Backlog, October 2019 Oct 8, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 22, 2019

I have pushed support for this.
I have tried it out and it seems to work nicely..
Please try it out in vscode insiders from Wednesday and let me know how it beahves

@isidorn isidorn mentioned this issue Oct 22, 2019
Closed
2 tasks
@isidorn isidorn mentioned this issue Oct 22, 2019
Closed
@guidobouman
Copy link
Author

@isidorn Thanks again for this! Brings VS Code one step closer to feature parity with (and ux triomph over) Visual Studio.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

@alexr00 alexr00

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@guidobouman @isidorn @dbaeumer @alexr00