Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set electron version in env scripts #45696

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Properly set electron version in env scripts #45696

merged 1 commit into from
Mar 14, 2018

Conversation

SteveDesmond-ca
Copy link
Contributor

Since the console.log() got removed from build/lib/electron.js, the npm_config_target environment variable wasn't getting set to anything.

This PR updates the scripts to call the getElectronVersion() method on build/lib/electron.js.

@SteveDesmond-ca SteveDesmond-ca mentioned this pull request Mar 13, 2018
Merged
@joaomoreno joaomoreno merged commit 13f3c4d into microsoft:master Mar 14, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Mar 14, 2018 •
edited

Oh wow. Thanks!

@joaomoreno joaomoreno added this to the March 2018 milestone Mar 14, 2018
@joaomoreno joaomoreno added vscode-build VS Code build process issues engineering VS Code - Build / issue tracking / etc. labels Mar 14, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
engineering VS Code - Build / issue tracking / etc. vscode-build VS Code build process issues
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SteveDesmond-ca @joaomoreno