Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a viewzone lags behind #45764

Closed
bpasero opened this issue Mar 14, 2018 · 3 comments
Closed

Dragging a viewzone lags behind #45764

bpasero opened this issue Mar 14, 2018 · 3 comments
Assignees
Labels
debt Code quality issues editor-symbols definitions, declarations, references
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 14, 2018

Steps to Reproduce:

  1. open a find references view zone
  2. drag it quickly up and down to resize

=> notice how the viewzone lags quit a bit in updating and even the editor text sometimes goes behind the viewzone

flicker_chrome58

@alexdima
Copy link
Member

Root cause is:

https://github.com/Microsoft/vscode/blob/a8839f858e6c7001262d8219da7593dd28cbdcf9/src/vs/editor/contrib/referenceSearch/media/referencesWidget.css#L12:L16

.monaco-editor .zone-widget .zone-widget-container.reference-zone-widget.results-loaded {
	-webkit-transition: height 100ms ease-in;
	transition: height 100ms ease-in;
}

@jrieken Blame does not help, as it looks we've had this forever. Should we just remove this rule?

@alexdima alexdima assigned jrieken and unassigned alexdima Apr 19, 2018
@bpasero
Copy link
Member Author

bpasero commented Apr 19, 2018

This is very old:

image

@jrieken jrieken added editor-symbols definitions, declarations, references debt Code quality issues labels Apr 19, 2018
@jrieken jrieken added this to the May 2018 milestone Apr 19, 2018
@jrieken
Copy link
Member

jrieken commented Apr 19, 2018

Yeah, lets nuke it

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues editor-symbols definitions, declarations, references
Projects
None yet
Development

No branches or pull requests

3 participants