Default npm package causes tasks to take a long time to start even when task detection is disabled

[jtokoph]

• VSCode Version: 1.21.1
• OS Version: Mac OSX 10.13.3

Steps to Reproduce:

1. Create workspace with large directory and file structure. Or clone one. (CocoaPods/Specs is a good example)
2. Create a task in tasks.json

{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "2.0.0",
  "tasks": [
    {
      "label": "echo",
      "type": "shell",
      "command": "echo Hello"
    }
  ]
}

3. Disable task autodetect in config:

"typescript.tsc.autoDetect": "off",
"jake.autoDetect": "off",
"gulp.autoDetect": "off",
"npm.autoDetect": "off",
"grunt.autoDetect": "off"

4. Go to Tasks -> Run Task...
5. Notice that it hangs for a long time
6. Run ps aux. See the following process running during the hang:

/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar.unpacked/vscode-ripgrep/bin/rg --files --hidden --case-sensitive -g **/package.json -g !**/node_modules/** -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !**/*.pyc --no-ignore --follow -- .

7. When running build task, you'll see Fetching build tasks... for a while.

Does this issue occur when all extensions are disabled?: Yes

I think this has caused a regression in performance and usability in large repositories.

The change here https://github.com/Microsoft/vscode/blob/a6dde81592febe579a24ada7b0e6d63b15a37cfd/extensions/npm/src/main.ts#L103 is calling vscode.workspace.findFiles before checking if the main workspace settings have npm.autoDetect set to on/off.

In my large workspaces I have disabled all *.autoDetect configuration options so that my default build task (cmd+shift+b) doesn't have to wait for vscode to look for all build tasks.

Before this change, my default build task started running immediately.
After this change, my default build task spends 20 seconds Fetching build tasks... before finally running my build script.

I believe this is a workflow breaking regression and have been forced to revert to the previous build of VSCode (1.20.x).

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Run the default build task from launch configuration (#32239)
• Improve Configure Default Build task in multi root setup (#35312)
• Tasks -> Configure Default Build Task does not preserve comments (#37138)
• Assign default task to last task I've run (#41455)
• g++ build Task can't find files on WSL (#33232)

[jtokoph]

I made a comment in the original issue that was used for tracking this change: #31217

[dbaeumer]

There is one additional task auto detection we ship auto of the box. It is "typescript.tsc.autoDetect": "off". Can you try to turn that off as well and see whether it makes a difference.

[jtokoph]

@dbaeumer copy paste error on my part, I already have that one disabled also and still run into the same issue. I'll update the original message to include it

[dbaeumer]

@jtokoph thanks. And actually after looking at the NPM code it is clear that the find causes the issue.

@egamma the problem is that you scan for all package.json files before checking if the feature is enabled or not. May be the scanning should happen per workspace folder based on the enablement setting.