Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination key in Teminal (Powershell) is not working #45940

Closed
jonathangc opened this issue Mar 16, 2018 · 7 comments
Closed

Combination key in Teminal (Powershell) is not working #45940

jonathangc opened this issue Mar 16, 2018 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@jonathangc
Copy link

Issue Type: Bug

In last update, the terminal (powershell) lost the functionality of the key combination (Ctrl + Shift + Left or Right arrow).

Windows 10 64bits.

VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz (8 x 2395)
Memory (System) 7.89GB (1.10GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (12)
Extension Author (truncated) Version
pgformatter bra 1.3.0
jshint dba 0.10.17
vscode-eslint dba 1.4.7
xml Dot 1.9.2
language-polymer jon 1.0.4
sublime-keybindings ms- 3.0.3
vscode-docker Pet 0.0.25
java red 0.20.0
vscode-java-debug vsc 0.7.0
vscode-java-pack vsc 0.3.0
vscode-java-test vsc 0.4.0
vscode-maven vsc 0.6.0

(1 theme extensions excluded)

Reproduces only with extensions
@Tyriar
Copy link
Member

Tyriar commented Mar 16, 2018

@jonathangc can you clarify what this did before?

You can get the old behavior by unbinding the resize keybindings. Add this to your keybindings.json:

{ "key": "ctrl+shift+left",         "command": "-workbench.action.terminal.resizePaneLeft",
                                     "when": "terminalFocus" },
{ "key": "ctrl+shift+right",        "command": "-workbench.action.terminal.resizePaneRight",
                                     "when": "terminalFocus" },

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Mar 16, 2018
@jonathangc
Copy link
Author

jonathangc commented Mar 16, 2018

@Tyriar
With the combination of keys:
ctrl+shift+right or left I could select the word in the console.
ctrl+backspace I could delete the word.

The functionality of this combination was replaced by resizePaneLeft and resizePaneRight.

I deleted this combination:
{ "key": "ctrl+cmd+left", "command": "-workbench.action.terminal.resizePaneLeft",
"when": "terminalFocus" },
{ "key": "ctrl+cmd+right", "command": "-workbench.action.terminal.resizePaneRight",
"when": "terminalFocus" },

After that, it works well.

@Tyriar Tyriar added terminal Integrated terminal issues windows VS Code on Windows issues labels Mar 19, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 19, 2018

@jonathangc @mlucic can you show me a screenshot of the selection? I can't get it to work using Windows 10 FCU with powershell.exe or the powershell extension set.

@mlucic
Copy link

mlucic commented Mar 19, 2018

@Tyriar

selection_example

@jonathangc
Copy link
Author

jonathangc commented Mar 19, 2018

Without resizePaneLeft shortcut (ctrl+shift+left)
combination_1

(ctrl+delete) is not working in VS Code.

VS Code
combination_2_vscode

PowerShell
combination_2_powershell

@Tyriar
Copy link
Member

Tyriar commented Mar 20, 2018

Thanks all, I got it working. I'm going to remove the resize keybindings on Windows as it appears cmder and conemu both use apps+shift+arrow. Our keybindings system doesn't support apps as a modifier (which is really weird) so I think we'll just leave it unbound by default on Windows.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 20, 2018
@Tyriar Tyriar added this to the March 2018 milestone Mar 20, 2018
@Tyriar Tyriar closed this as completed in 38bb950 Mar 20, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 28, 2018

I removed the keybinding, selection in PS now works with the defaults.

@Tyriar Tyriar added the verified Verification succeeded label Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

3 participants