Simple widget editor that is hidden from extensions #46169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do not intercept commands
isidorn
changed the title
alexdima
reviewed
Mar 20, 2018
| @@ -33,6 +33,7 @@ import { Color } from 'vs/base/common/color'; | |||
| import { IMouseEvent } from 'vs/base/browser/mouseEvent'; | |||
| import { ClassName } from 'vs/editor/common/model/intervalTree'; | |||
| import { ITextModel, IModelDecorationOptions } from 'vs/editor/common/model'; | |||
| import { ICommandDelegate } from '../view/viewController'; | |||
| /** | ||
| * A context key that is set when any editor input has focus (regular editor, repl input...). | ||
| */ | ||
| export const inputFocus = new RawContextKey<boolean>('inputFocus', false); |
There was a problem hiding this comment.
Let's ask in the stand-up what would be a good name. Perhaps textInputFocus is better than inputFocus, as there might in the future be other types of inputs, like drop downs or radio buttons...
| @@ -30,7 +30,7 @@ export class ReplInputEditor extends CodeEditorWidget { | |||
| @IContextKeyService contextKeyService: IContextKeyService, | |||
| @IThemeService themeService: IThemeService | |||
| ) { | |||
| super(domElement, options, instantiationService, codeEditorService, commandService, contextKeyService, themeService); | |||
| super(domElement, options, true, instantiationService, codeEditorService, commandService, contextKeyService, themeService); | |||
There was a problem hiding this comment.
Let's postpone turning the flag to true here until we get the commands sorted out. Otherwise, I don't think cursor left/cursor right will work in the repl.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46112
Introduces a new "type" of editor that will not be sent to extensions. Work that needs to be done:
isSimpleWdigetflag such that basic commands are not sent via command service so extensions can not intercepteditorTextFocusto not be set for simple editorsinputFocuswhich will be set for both simple and regular editorstextFocus(probably will not be a part of this PR due to large number of files touched)