"Open Folder" dialog is prefilled with non-existent "lib" folder

[DanTup]

This has been bugging me for days and I can't figure out where it's coming from. I'm debugging my extension in the dev host and when I click "Open Folder" it defaults to the last folder I opened, but the box at the bottom is prefilled with lib (which doesn't exist). This means I can't just hit <enter> but have to clear the text first.

I tried clearing my recent list but it still persists.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Typescript Language service not finding symbolic linked (junction) npm module (#25312)

[bpasero]

@DanTup I have no clue what could trigger this other than suspect a Windows issue.

[bpasero]

@DanTup actually we seem to prefill a default path, can you add a breakpoint here and see what the default path resolves to?

[DanTup]

@bpasero What's the correct way to do that? I tried opening dev tools, finding it in the file and adding breakpoints (I added a bunch) but they don't seem to be hit.

[bpasero]

@DanTup that is weird, maybe a different action gets executed, we can start one level before here maybe: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/views/emptyView.ts#L63

[DanTup]

Not hitting that either :( I opened emptyView.ts using Ctrl+P and when I added a breakpoint there, it jumped me over the the JS (where I'd already placed a BP), so seems it's not hitting them set from JS or TS. Breakpoints are definitely active :/

I tried searching through Local Storage in the dev tools and found lots of paths around this folder, but none that have lib directly have flutter (with either slash, single or doubled). Do you know where it's intended to get it from?

[bpasero]

@DanTup did you maybe disable sourcemaps in dev tools? For me the breakpoint gets hit once I click on the button:

[DanTup]

Aha, I think prettifying the JS view was breaking it - opening the .ts file first worked.

Here's the path that's being passed - this path does not not exist anymore - I guess it's using the last part of it still!

And here's a search through local storage for hhhhhhhh.. This doesn't show on the File -> Open recent list though.

I guess a fix could be to ensure paths exist before using them as default locations for the Open dialog?

[bpasero]

@DanTup can you open a file and then run these steps again? I think we have some code that uses a path based on the last active file that was opened. That could be it.

[DanTup]

Yeah, I opened another file then closed gracefully and it's stopped happening. I guess mostly the dev host just gets terminated by my hitting Restart/Stop in the main Code instance so it doesn't update.

[bpasero]

I pushed a fix to check for existence of the dialog default path before showing the dialog and otherwise not setting the path at all.