Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Terminal Command based on Workspace Path #45694 #46461

Merged
merged 2 commits into from
Apr 2, 2018

Conversation

knyhle
Copy link
Contributor

@knyhle knyhle commented Mar 24, 2018

Add feature requested: #45694

Made Split Terminal work like the Create Terminal command including (In Active Workspace) option.

out

@msftclas
Copy link

msftclas commented Mar 24, 2018

CLA assistant check
All CLA requirements met.

@Tyriar
Copy link
Member

Tyriar commented Mar 27, 2018

Thanks @kennyle1412! I'll check this out soon for the April release as we're currently in endgame/testing for the March release. Could you fix the conflicts in the meantime?

@knyhle
Copy link
Contributor Author

knyhle commented Mar 27, 2018

@Tyriar yeah, no problem! Take as long as you need.

Copy link

@nzec nzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

Similar functionality to CreateTerminalInActiveWorkspace for
CreateTerminal for no prompt creation.
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyle1412 really nice PR! 👍

@Tyriar Tyriar merged commit 97dcb55 into microsoft:master Apr 2, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants