Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode button styles are inconsistent in some places #46490

Closed
kumarharsh opened this issue Mar 25, 2018 · 5 comments
Closed

VSCode button styles are inconsistent in some places #46490

kumarharsh opened this issue Mar 25, 2018 · 5 comments
Assignees
Labels
issue-reporter Issue reporter widget issues polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@kumarharsh
Copy link
Contributor

  • VSCode Version: 1.21.1
  • OS Version: Win10Pro

A. The feedback button has a 4px wide border, and the space around button's icon is not balanced at all. The font size of the button is 12.1px (馃)
image

B. Whereas the "Report an Issue" window has wildly different styles for the button:

  1. Padding is much lesser than Tweet button.
  2. Font size is 16px.
  3. Space is balanced, but no icon is there.
  4. Border radius is 0.25rem (which evaluates to 4px, but why in rem here, or vice-versa?)
    image

Plus, the inputs in the issue reporter form (at least) is very different from the rest of the vscode UI - round borders and bigger font-sizes all around.

@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Mar 25, 2018
@bpasero
Copy link
Member

bpasero commented Mar 25, 2018

For the feedback twitter button I would accept a PR that leverages our Button widget to have a consistent look.

/cc @RMacfarlane for the issue reporter, are you using our Button widget there?

@bpasero bpasero added help wanted Issues identified as good community contribution opportunities layout General VS Code workbench layout issues and removed editor editor-core Editor basic functionality labels Mar 25, 2018
@bpasero bpasero self-assigned this Mar 25, 2018
@bpasero bpasero added workbench-feedback and removed layout General VS Code workbench layout issues labels Mar 25, 2018
@kumarharsh
Copy link
Contributor Author

ok. on it.

@kumarharsh
Copy link
Contributor Author

It seems like the <Button> element doesn't have a way to access the Builder object. From what I've seen in the code, the Builder is a much more powerful and easy-to-use wrapper over the HTMLElement. It might be quite useful in this case to expose the underlying Builder object from the Button (Button.$el). Just a thought...

I've made the PR.

@RMacfarlane
Copy link
Contributor

@bpasero no, the issue reporter isn't using the Button widget either

@bpasero bpasero added issue-reporter Issue reporter widget issues and removed help wanted Issues identified as good community contribution opportunities workbench-feedback labels Mar 26, 2018
@bpasero bpasero assigned RMacfarlane and unassigned bpasero Mar 26, 2018
@bpasero
Copy link
Member

bpasero commented Mar 26, 2018

@RMacfarlane moving the remainder to you then. the feedback issue is fixed thanks to #46503

@RMacfarlane RMacfarlane added this to the May 2018 milestone May 4, 2018
@RMacfarlane RMacfarlane added the polish Cleanup and polish issue label May 4, 2018
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue-reporter Issue reporter widget issues polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants