Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed terminal doesn't open when window has no folders, fixes #46139 #46518

Merged
merged 3 commits into from
Mar 31, 2018
Merged

fixed terminal doesn't open when window has no folders, fixes #46139 #46518

merged 3 commits into from
Mar 31, 2018

Conversation

alexglazkov9
Copy link
Contributor

fixes #46139

@dbaeumer dbaeumer added the terminal Integrated terminal issues label Mar 26, 2018
@Tyriar Tyriar added this to the April 2018 milestone Mar 31, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2018

Thanks @alexglazkov9, I added a null check to cover the edge case when you run the command before any files have been opened (open a folder, close a folder, run command).

@Tyriar Tyriar merged commit feec68e into microsoft:master Mar 31, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
terminal Integrated terminal issues
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.

"Open in Terminal" does not work when window has no folders
3 participants
@alexglazkov9 @Tyriar @dbaeumer