Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing type and label from IRawEnvAdapter #46550

Closed
isidorn opened this issue Mar 26, 2018 · 2 comments
Closed

Consider removing type and label from IRawEnvAdapter #46550

isidorn opened this issue Mar 26, 2018 · 2 comments
Assignees
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 26, 2018

Also check whether some debug extension is actually using the type and label as platform specific in their package.json.

If not we might want to consider to move "type" and "label" to "IRawAdapter" (where other non-platform specific attributes live).

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Mar 26, 2018
@isidorn isidorn added this to the April 2018 milestone Mar 26, 2018
@isidorn isidorn self-assigned this Mar 26, 2018
@weinand
Copy link
Contributor

weinand commented Apr 17, 2018

The IRawAdapter got renamed to IDebuggerContribution and the code that deals with platform specific package.json attributes neither handles 'type' or 'label'.

@isidorn
Copy link
Contributor Author

isidorn commented Apr 17, 2018

@weinand I have remove the type and label from the IPlatformSpecific interface. Note that I have added some return types to methods because I like to always explicitly write them even for void. And I prefer destructured imports so I also changed that a bit.

@weinand weinand added the verified Verification succeeded label Apr 23, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants