Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If I want to have a preselected item I need to provide a description #46657

Closed
dbaeumer opened this issue Mar 27, 2018 · 1 comment
Closed

If I want to have a preselected item I need to provide a description #46657

dbaeumer opened this issue Mar 27, 2018 · 1 comment
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
March 2018

Comments

@dbaeumer
Copy link
Member

Tests #46587

So far the simple single picker allowed me to have a list of single labels. If I want to have a pre-selected item this is not possible anymore since the QuickPickItem item type forces me to provide a description. We should either make the description optional or make a more complicated OR type which allows to have the description optional if selected true.
@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Mar 27, 2018
@chrmarti chrmarti added this to the March 2018 milestone Mar 27, 2018
@chrmarti
Copy link
Contributor

Good catch. We should make QuickPickItem.description optional. /fyi @jrieken

@chrmarti chrmarti added the quick-pick Quick-pick widget issues label Mar 27, 2018
@jrieken jrieken added the verified Verification succeeded label Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
3 participants
@jrieken @dbaeumer @chrmarti