"Close to the Right" Sometimes Tries to Close Unsaved Files to the Left

[sebmarkbage]

• VSCode Version: 1.21.1
• OS Version: macOS 10.13.3

I can't consistently reproduce it but it is possible to get into a bad state where newly created and unsaved files (Untitled-#) has this issue. The newly created unsaved files are lined up on the left after reopening the project (e.g. after an upgrade) and other files to the right of them.

After trying to close a set of files to the right using "Close to the Right". The view switches to one of the unsaved files to the left and a popup asks me to save them. It was trying to close files that I didn't intent to close and then I'm forced to cancel. Which leaves me with all files still open.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Close All should not stop when unsaved files encountered (#43909)

[bpasero]

@sebmarkbage can you show a screenshot when this happens or a video?

[sebmarkbage]

[bpasero]

@sebmarkbage I am having a hard time to see an issue in your gif

[sebmarkbage]

@bpasero See how when I click "Close to the Right" on test.js, it tries to close the tab to the left (Untitled-8). It shouldn't try to close any of the tabs to the left.

[bpasero]

@sebmarkbage I see, yes that looks like a bug. But I tried to reproduce this and I cannot, no matter what I try. So there must be steps involved that I am not doing. Can you try to reproduce this from our insider release (nightly builds) and if you can, remember what exact steps you did?

You can give our preview releases a try from: https://code.visualstudio.com/insiders/

[ghost]

I'm hitting this as well, both on the insider build (6b4d53c) and the latest stable (1.21.1).

Here are the steps to repro:

1. Open a new window (Ctrl + Shift + N)
2. Close the welcome tab (Ctrl + W)
3. Open 3 new files (Ctrl + N)
4. Left-click on "Untitled-1" and type something in it
5. Right-click "Untitled-2" and select "Close to the Right"
6. Open a new file (Ctrl + N)
7. Right-click on "Untitled-2" and select "Close to the Right"
8. Bug will trigger here!

[bpasero]

@aleksijuvani thanks for the steps, I can reproduce that.