Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different border styles for HC (#45479) #46956

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Different border styles for HC (#45479) #46956

merged 1 commit into from
Apr 4, 2018

Conversation

svipas
Copy link
Contributor

@svipas svipas commented Mar 29, 2018 •
edited

Fixes #45479

  • Changed all these new border colors to have solid instead of dotted | dashed. Using dotted | dashed only if the theme is HC.
  • Changed diffEditor.insertedTextBorder and diffEditor.removedTextBorder to be solid instead of dashed. Using dashed only if the theme is HC.

/cc @alexandrudima

@svipas svipas mentioned this pull request Mar 29, 2018
Closed
@svipas
Copy link
Contributor Author

svipas commented Mar 29, 2018

Seems there is some telemetry error and tests are failing. And I believe this happened after this commit 21bfdd4.

@svipas
Copy link
Contributor Author

svipas commented Mar 29, 2018

Seems test are again stable and successful, how to trigger them to build again for this PR?

@alexdima
Copy link
Member

alexdima commented Apr 4, 2018

👍 Nice! Thank you!

@alexdima alexdima added this to the April 2018 milestone Apr 4, 2018
@alexdima alexdima merged commit 44b3ee2 into microsoft:master Apr 4, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.

Borders styles for selection and word highlight
2 participants
@svipas @alexdima