Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a method of matching TaskExecution objects #47465

Closed
alpaix opened this issue Apr 9, 2018 · 4 comments
Closed

Provide a method of matching TaskExecution objects #47465

alpaix opened this issue Apr 9, 2018 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan tasks Task system issues
Milestone

Comments

@alpaix
Copy link

alpaix commented Apr 9, 2018

Problem

The extended task API introduced a new concept of task executions. When executeTask method is called it returns a TaskExecution instance I'd wanted to keep for later. Then after the task terminates it raises onDidEndTask event with another TaskExecution instance attached to it which I cannot match against the first instance I kept as they are not ===.

Suggestion

Provide a method of matching task execution objects or giving it a unique ID or similar.

@vscodebot
Copy link

vscodebot bot commented Apr 9, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the tasks Task system issues label Apr 9, 2018
@alpaix
Copy link
Author

alpaix commented Apr 9, 2018

One more request is to provide a query to fetch all task executions. Is it possible to add to the API?

@dbaeumer
Copy link
Member

dbaeumer commented Apr 9, 2018

@alpaix I will look into making the task execution object ===.

Can you please open another issue for the query. Makes it easier for me to track and close.

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Apr 9, 2018
@dbaeumer dbaeumer added this to the April 2018 milestone Apr 9, 2018
@dbaeumer
Copy link
Member

Tested via LiveShare team.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants