CodeActionProvider.providedKinds #47702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We pass this information along the register-call because that makes it clear that those cannot change. Making it a property, apart from being different to other places, makes this harder to watch |
Adds a new optinal `providedKinds` property on `CodeActionProvider`. This is a list of `CodeActionKinds` that the provider may return. The list is used for deciding when to show the `refactor` and `source action` context menus. It is not used for filtering the returned code actions Possibly helps address microsoft#45383
…a code action provider
mjbvz
force-pushed
the
codeaction-provided-kinds
branch
from
b1b0e66
to
b7d523a
Compare
|
There's no milestone on this but the changes are in vscode.d.ts - I presume this plans to ship in 1.23? Edit: Looks like #47621 is tagged April :) |
|
@mjbvz Is it possible to change the label that appears for "Organize Imports"? It doesn't seem to use the name form the Code action (in the palette). For ex in Dart we call it "Organize Directives" and I guess C# calls it |
1 task
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 24, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
|
The command itself is called organize imports for consistency across languages. However the code action entry in the |
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 25, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 25, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 26, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 26, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 26, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 26, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Apr 30, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
May 2, 2018
Implements microsoft/vscode#47702 so that we get refactors on context menu. Fixes #835. Fixes #531 (ish).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new optinal
providedKindsproperty onCodeActionProvider. This is a list ofCodeActionKindsthat the provider may return. The list will be used for deciding when to show therefactorandsource actioncontext menus. It is not used for filtering the returned code actionsPossibly helps address #45383