You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have solved this by not centering the binary editor. @bpasero notice that I have moved all the editor type ids from files.ts to editor.ts
Currently they were spread in those two files which felt a bit shaky to me (I might ahve introduced this initially).
Let me know if you do not like them in editor.ts and we can figure out a different way to determine the type of an editor.
@isidorn the preferences, file and binary file editor are being contributed to the workbench from vs/workbench/parts. Moving knowledge of them into editor.ts (which is a core workbench piece) is a layer breaker we should try to avoid. The following IDs should move out again:
PREFERENCES_EDITOR_ID
TEXT_FILE_EDITOR_ID
FILE_EDITOR_INPUT_ID
BINARY_FILE_EDITOR_ID
If we need to check on some property to decide to do something (like centering or not), we could have another method on editor input similar to supportsSplitEditor to answer that.
@bpasero makes sense. I have made the changes to move this back into it's appropraite layer, however now I seem to be hitting the following issue
Open an editor, go into center mode
Open preferences editor
Layout is called -> I need to figure out if I should center, however the preferences editor still does not have input asociated with it - it is null. Thus I can not ask the input if it supports centered editor
The text was updated successfully, but these errors were encountered: