Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad user experience when installing incompatible extension version using VSIX #47828

Closed
defr0std opened this issue Apr 13, 2018 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone

Comments

@defr0std
Copy link

  • VSCode Version: 1.21
  • OS Version: Any

Steps to Reproduce:

  1. Make an extension which specifies minimum required VSCode version 1.22
  2. Build extension and install from VSIX using VSCode 1.21

Expected: a UI notification saying that Extension XXX requires VSCode version 1.22 or higher.

Actual result: no error/warning is shown in the VSCode UI telling the user that the extension requires a newer VSCode version.
Extension is just shown as not loaded, clicking "Reload" button reloads the UI, but nothing changes.

This is how it looks:
image

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Apr 13, 2018
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Apr 16, 2018
@sandy081 sandy081 added this to the April 2018 milestone Apr 16, 2018
@sandy081 sandy081 changed the title Bad user experience when installing incompatible extension version Bad user experience when installing incompatible extension version using VSIX Apr 18, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 26, 2018
@RMacfarlane
Copy link
Contributor

@sandy081 The notification shows as expected, but I think it would be good to include the required engine version in the error message

@sandy081
Copy link
Member

@RMacfarlane Not sure if that is helpful to the user because we do not support downgrading of VS Code. Since user knows the current version of VS Code, user can file an issue against extension that it is not getting installed with given version.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants