Spelling #47894

jsoref · 2018-04-15T05:58:33Z

Hi. I don't expect you to want to take this PR as is.

I'm quite happy to split this into a number of different PRs, to collapse commits, and to perform other tasks as requested.

If there are certain files that you don't want changed, I can certainly drop them.

For reference, I ignore certain files -- by deleting them -- you can see which I ignored at: https://github.com/jsoref/vscode/tree/ignore

In general, I try to keep commits unsquashed until a PR is ready to be accepted, because it makes it easier to manage (rebase) merge conflicts or to drop a word in case it turns out it's intentional.

Often, I'm asked to split off PRs by categories, such as:

Comments
Documentation
Strings
Variables
Functions
API breaks

If you have a preferred set, please let me know.

jsoref · 2018-04-15T06:03:27Z

extensions/html-language-features/server/src/modes/languageModes.ts

@@ -15,7 +15,7 @@ import { FoldingRange } from 'vscode-languageserver-protocol-foldingprovider';
 import { getLanguageModelCache, LanguageModelCache } from '../languageModelCache';
 import { getDocumentRegions, HTMLDocumentRegions } from './embeddedSupport';
 import { getCSSMode } from './cssMode';
-import { getJavascriptMode } from './javascriptMode';
+import { getJavaScriptMode } from './javascriptMode';


In general, JavaScript is a brand and there are only two proper ways to spell it: JavaScript, or javascript. As javascriptMode is probably a module, I probably should drop this.

jsoref · 2018-04-15T06:04:25Z

extensions/html-language-features/server/src/test/completions.test.ts

@@ -76,7 +76,7 @@ export function testCompletionFor(value: string, expected: { count?: number, ite
 }

 suite('HTML Completion', () => {
-	test('HTML Javascript Completions', function (): any {
+	test('HTML JavaScript Completions', function (): any {


Here's a case where JavaScript should be properly spelled...

jsoref · 2018-04-15T06:06:39Z

extensions/markdown-language-features/src/commands/showPreview.ts

@@ -67,7 +67,7 @@ async function showPreview(

 	telemetryReporter.sendTelemetryEvent('openPreview', {
 		where: previewSettings.sideBySide ? 'sideBySide' : 'inPlace',
-		how: (uri instanceof vscode.Uri) ? 'action' : 'pallete'
+		how: (uri instanceof vscode.Uri) ? 'action' : 'palette'


I know that a lot of the changes here are to telemetry calls, which presumably will impact a database somewhere.
I'd argue that changing to the correct spelling and at worst adding a shim/collator for the backend is the right thing to do.

That said, I'm happy to drop these things if requested.

jsoref · 2018-04-15T06:13:32Z

src/typings/node.d.ts

@@ -5163,7 +5163,7 @@ declare module "crypto" {
        sign(private_key: string | { key: string; passphrase: string }): Buffer;
        sign(private_key: string | { key: string; passphrase: string }, output_format: HexBase64Latin1Encoding): string;
    }
-    export function createVerify(algorith: string): Verify;
+    export function createVerify(algorithm: string): Verify;


I'm assuming that changes like this aren't a significant thing.

jsoref · 2018-04-15T06:14:32Z

src/vs/editor/contrib/smartSelect/tokenTree.ts

@@ -400,7 +400,7 @@ class TokenTreeBuilder {

 /**
 * Parses this grammar:
- *	grammer = { line }
+ *	grammar = { line }


I hope this isn't a problem :-)

jsoref · 2018-04-15T06:15:00Z

src/vs/editor/contrib/snippet/snippetSession.ts

@@ -123,7 +123,7 @@ export class OneSnippet {
 				}
 			}

-			// change stickness to never grow when typing at its edges
+			// change stickiness to never grow when typing at its edges


I'm not actually sure about this one

jsoref · 2018-04-15T06:17:12Z

src/vs/platform/instantiation/test/common/instantiationService.test.ts

@@ -155,7 +155,7 @@ suite('Instantiation Service', () => {
 		assert.ok(collection.has(IService2));
 	});

-	test('@Param - simple clase', function () {
+	test('@Param - simple case', function () {


I'm not sure about this

jsoref · 2018-04-15T06:37:57Z

build/tfs/common/symbols.ts

@@ -171,12 +171,12 @@ async function ensureVersionAndSymbols(options: IOptions) {
 }

 // Environment
-const pakage = require('../../../package.json');
+const pkg = require('../../../package.json');


I understand that package is a reserved word.

Generally, instead of a random misspelling, people use an abbreviation, I've picked pkg (and Travis doesn't seem to object). I'm flexible, in case you have a preference. Other alternatives include using a _...

joaomoreno · 2018-04-16T08:02:51Z

@jsoref We don't take PR's that don't bring any improvement to the product itself. Typos are OK to have, especially in comments.

If you want to contribute to the project I suggest to go through https://github.com/Microsoft/vscode/wiki/How-to-Contribute

jsoref

@joaomoreno: thanks for your feedback.

I'm not going to argue what does improve a given product, that's of course your project's choice. My personal view is that misspellings make it harder to search for things and harder to understand, contextualize, localize, or even fix things.

What would be helpful is a sense of which things do "improve" your product per your definition.

As a potential English speaking user of your project, I'd expect that user interface elements and messages would be improved by having correct spelling, would changes to that effect count as an improvement per your definition?

jsoref · 2018-04-16T11:06:26Z

extensions/html-language-features/server/src/htmlServerMain.ts

 		}
 		return null;
-	}, null, `Error while computing signature help for ${signatureHelpParms.textDocument.uri}`, token);
+	}, null, `Error while computing signature help for ${signatureHelpParams.textDocument.uri}`, token);


This feels like output, would you take changes like this?

jsoref · 2018-04-16T11:19:37Z

extensions/git/src/commands.ts

@@ -972,8 +972,8 @@ export class CommandCenter {

 			if (unsavedTextDocuments.length > 0) {
 				const message = unsavedTextDocuments.length === 1
-					? localize('unsaved files single', "The following file is unsaved: {0}.\n\nWould you like to save it before comitting?", path.basename(unsavedTextDocuments[0].uri.fsPath))
-					: localize('unsaved files', "There are {0} unsaved files.\n\nWould you like to save them before comitting?", unsavedTextDocuments.length);
+					? localize('unsaved files single', "The following file is unsaved: {0}.\n\nWould you like to save it before committing?", path.basename(unsavedTextDocuments[0].uri.fsPath))


This is definitely a user visible message. Would you take a series that only changed the English output for nls.localize(..., "...")?

joaomoreno · 2018-04-17T07:23:18Z

As a potential English speaking user of your project, I'd expect that user interface elements and messages would be improved by having correct spelling, would changes to that effect count as an improvement per your definition?

@jsoref Absolutely! You can submit PRs fixing up user-facing labels, we'll take them gladly!

jsoref added 30 commits April 11, 2018 01:50

spelling: character

9bef7bd

spelling: chose

e0598af

spelling: clipboard

169e4d5

spelling: closing

304631f

spelling: collapse

316e97e

spelling: command

010e020

spelling: comparison

920f24e

spelling: comment

151d7c7

spelling: committing

a7502fa

spelling: completely

aa7ad81

spelling: completion

83146dc

spelling: components

f8c917b

spelling: condition

9bef3ef

spelling: context

4895dc4

spelling: content

50ac08b

spelling: contribution

eed6c28

spelling: controller

541d12e

spelling: convenience

06cec73

spelling: convenient

8a30e60

spelling: correspondent

90fe7e9

spelling: debuggee

1a29c86

spelling: declaration

f9c98c6

spelling: delimiter

1baff95

spelling: decorations

538c10c

spelling: definition

34f0938

spelling: dependencies

4837c91

spelling: depending

b121a47

spelling: description

0a08bc0

spelling: delivered

0b9f94b

spelling: delta

c7c12da

jsoref added 17 commits April 15, 2018 03:27

spelling: whether

686d387

spelling: whitespace

563bd1f

spelling: without

0160fa7

spelling: window

43be189

spelling: windows

8f449be

spelling: with

d622430

spelling: workbench

f74b2ca

spelling: workspace

633100d

spelling: zooming

16b9eff

spelling: configuration

30fa0cb

spelling: container

04b4550

spelling: eventually

46c4ae0

spelling: exceeding

22b744c

spelling: organize

3a63566

spelling: orientation

2f7398d

spelling: serialized

865774d

spelling: serializer

8f1cda9

jsoref commented Apr 15, 2018

View reviewed changes

jsoref added 2 commits April 15, 2018 06:21

spelling: pkg

75ae8b3

spelling: palette

82c3bd7

jsoref force-pushed the spelling branch from 08d4b1b to 16b9eff Compare April 15, 2018 06:27

jsoref commented Apr 15, 2018

View reviewed changes

joaomoreno closed this Apr 16, 2018

jsoref commented Apr 16, 2018

View reviewed changes

aeschli added a commit that referenced this pull request Apr 16, 2018

css/html/json typos (for #47894)

6657623

github-actions bot locked and limited conversation to collaborators Mar 27, 2020

jsoref deleted the spelling branch October 29, 2020 23:46

jsoref restored the spelling branch October 30, 2020 00:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #47894

Spelling #47894

jsoref commented Apr 15, 2018 •

edited

jsoref Apr 15, 2018

jsoref Apr 15, 2018

jsoref Apr 15, 2018

jsoref Apr 15, 2018

jsoref Apr 15, 2018

jsoref Apr 15, 2018

jsoref Apr 15, 2018

jsoref Apr 15, 2018

joaomoreno commented Apr 16, 2018 •

edited

jsoref left a comment

jsoref Apr 16, 2018

jsoref Apr 16, 2018

joaomoreno commented Apr 17, 2018 •

edited

Spelling #47894

Spelling #47894

Conversation

jsoref commented Apr 15, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joaomoreno commented Apr 16, 2018 • edited

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joaomoreno commented Apr 17, 2018 • edited

jsoref commented Apr 15, 2018 •

edited

joaomoreno commented Apr 16, 2018 •

edited

joaomoreno commented Apr 17, 2018 •

edited