Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsalinger/multipath wrong rename message #48102

Merged
merged 5 commits into from
Apr 18, 2018

Conversation

tsalinger
Copy link
Contributor

fixes #44544
fixes #44548

- prevents weird message in inputbox
@isidorn
Copy link
Contributor

isidorn commented Apr 18, 2018

I tried this and it looks good.
Please resolve conflicts with master, and one nitbit
The message seems confusing when I just try to create a file ab/ top level, it says:

screen shot 2018-04-18 at 12 16 20

@isidorn isidorn added this to the April 2018 milestone Apr 18, 2018
@isidorn
Copy link
Contributor

isidorn commented Apr 18, 2018

Looks good, merging in. Thanks

@isidorn isidorn merged commit 9b0ed06 into master Apr 18, 2018
@isidorn isidorn deleted the tsalinger/multipath-wrong-rename-message branch April 18, 2018 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help message is wrong when renaming Help message is confusing
2 participants