Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[themes] Solarized Dark selection color has no enough contrast #48106

Closed
siburuxue opened this issue Apr 18, 2018 · 6 comments
Closed

[themes] Solarized Dark selection color has no enough contrast #48106

siburuxue opened this issue Apr 18, 2018 · 6 comments
Assignees
@aeschli
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues themes Color theme issues verified Verification succeeded
Milestone
May 2018

Comments

@siburuxue
Copy link

Issue Type: Feature Request

在使用Solarized Dark主题时，当选中一些文字之后，被选中的文字的背景颜色和主题背景色的颜色反差太小，导致根本看不清这些文字是否被选中

VS Code version: Code 1.22.2 (3aeede7, 2018-04-12T16:32:53.389Z)
OS version: Darwin x64 17.5.0
@vscodebot
Copy link

vscodebot bot commented Apr 18, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@ghost
Copy link

ghost commented Apr 18, 2018

@siburuxue : Can you show us a mp4 in a zip file by submitting it to re-produce the issue?

@ramya-rao-a
Copy link
Contributor

@siburuxue Please provide a screenshot of the problem

@ramya-rao-a ramya-rao-a added the info-needed Issue requires more information from poster label Apr 19, 2018
@siburuxue
Copy link
Author

siburuxue commented Apr 19, 2018 •
edited

test.mp4.zip
这个是我录制的视频@MaleDong

@ramya-rao-a ramya-rao-a added themes Color theme issues accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed info-needed Issue requires more information from poster labels Apr 19, 2018
@ghost
Copy link

ghost commented Apr 20, 2018

@siburuxue ：Thanks. But I cannot open the mp4 to see what's happening……
And what's more, it seems that Microsoft member has opened that to analyze the problem……Let's wait for them:)

@siburuxue
Copy link
Author

@MaleDong 可能是我之前录的内容解释的不详细 我重新录了一遍 地址：http://121.42.230.254/mov.zip

@aeschli aeschli added the info-needed Issue requires more information from poster label May 2, 2018
@aeschli aeschli changed the title 使用Solarized Dark 主题的过程中出现的问题 [themes] Solarized Dark selection color has no enough contrast May 2, 2018
@aeschli aeschli removed the info-needed Issue requires more information from poster label May 2, 2018
@aeschli aeschli added this to the May 2018 milestone May 2, 2018
@aeschli aeschli closed this as completed in 24b5f19 May 2, 2018
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
3 participants
@aeschli @siburuxue @ramya-rao-a