improves validation on rename #48117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsalinger please resolve conflicts against latest master and then I will review this. |
isidorn
requested changes
Apr 18, 2018
| if (names.length > 1) { // error only occurs on multi-path | ||
| const comparer = isLinux ? strings.compare : strings.compareIgnoreCase; | ||
| if (comparer(names[0], this.element.name) === 0) { | ||
| return nls.localize('renameWhenSourcePathIsParentOfTargetError', "Cannot move/copy when source path is parent of target path."); |
There was a problem hiding this comment.
I would improve this message to somehow be more clear and user friendly.
Also "move/copy" I prefer "move or copy"
|
@tsalinger thanks for this PR, merging in. |
isidorn
deleted the
tsalinger/fixes-#47791-improving-validation-on-rename
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47791
fixes #44549