Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal pty size is not initialized #48136

Closed
Tyriar opened this issue Apr 18, 2018 · 2 comments
Closed

Terminal pty size is not initialized #48136

Tyriar opened this issue Apr 18, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 18, 2018

I believe after splits was implemented the initial size of the pty is not being set. This means that wrapping could look wrong for the first few lines before a resize is performed (after attachToElement is called).

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 18, 2018
@Tyriar Tyriar added this to the April 2018 milestone Apr 18, 2018
@Tyriar Tyriar self-assigned this Apr 18, 2018
@Tyriar Tyriar modified the milestones: April 2018, May 2018 Apr 23, 2018
@Tyriar Tyriar modified the milestones: May 2018, Backlog May 25, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2018

Since split terminals were added the container has not been set when terminals are created, this means that ptys get intiialized with 80 columns which can cause some weird wrapping. The right fix for this is tricky after the introduction of split terminals.

@Tyriar Tyriar modified the milestones: Backlog, August 2018 Aug 21, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2018

We could defer the creation of all terminal processes until the container is visible if we know it's going to be visible. We can even cover most cases where the terminal is not visible such as created via extension host by caching the dimensions (there was some code that did this pretty well before splits was added).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants