Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets docs becomes frozen when using useCodeSnippetsOnMethodSuggest #48368

Closed
user3323 opened this issue Apr 23, 2018 · 8 comments
Closed
Assignees
Labels
*not-reproducible Issue cannot be reproduced by VS Code Team member as described suggest IntelliSense, Auto Complete typescript Typescript support issues

Comments

@user3323
Copy link

  • VSCode Version: 1.23.0-ins
  • OS Version: win7x64
Version 1.23.0-insider
Commit c1cd4378c5e5dc434ed959e13556d05240a8ca18
Date 2018-04-20T05:17:25.189Z
Shell 2.0.0-beta.7
Renderer 61.0.3163.100
Node 8.9.3
Architecture x64

exts disabled


xxx.component.ts

import { Component } from '@angular/core';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  animations: [
    
  ]
})
export class AppComponent {
}


Snippets list gets frozen state on different items of the list.

GIF:
snippets list frozen

One more example:

trigger

Maybe the problem is in the duplicated useless items in the list, but not sure.

@ramya-rao-a ramya-rao-a self-assigned this Apr 23, 2018
@ramya-rao-a ramya-rao-a added the suggest IntelliSense, Auto Complete label Apr 23, 2018
@ramya-rao-a ramya-rao-a added this to the April 2018 milestone Apr 23, 2018
@ramya-rao-a
Copy link
Contributor

@user3323 Do you have emmet enabled for this file type? Do you still see this issue if you disable emmet? Try adding the below in your settings to test this theory:

"emmet.showExpandedAbbreviation": "never"

@user3323
Copy link
Author

@ramya-rao-a , hello.

I figured out what an option makes a problem:

"typescript.useCodeSnippetsOnMethodSuggest": true

GIF:
ts option makes freeze

@ramya-rao-a
Copy link
Contributor

Is there any codebase that we can try and repro this?
Or can you provide a sample code that we can use?

#47988 is similar to this issue, but has nothing to do with "typescript.useCodeSnippetsOnMethodSuggest": true

@user3323
Copy link
Author

@ramya-rao-a

node_modules ---> @angular
src ---> qqq.ts

snippets_list_frozen.zip


I cannot repro it in stable build (TypeScript v2.8.1):

Version 1.22.2
Commit 3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9
Date 2018-04-12T16:38:45.278Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

... so, it happens only in Insiders (TypeScript v2.8.3):

Version 1.23.0-insider
Commit b845ce918f2689344795e845ae6ef691916c3079
Date 2018-04-24T05:17:07.677Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

@user3323
Copy link
Author

@ramya-rao-a
and about similarity of issues.. well, I think it only looks like that (but not), because in the instances and repros you can face both of them simultaneously...
#47988 is more like my another issue #46457 (that moment I thought it was an extension problem)... then microsoft/TypeScript#23087 was created to track it, and yesterday it was labeled as bug, and fixed already (cannot test it)

@ramya-rao-a
Copy link
Contributor

Thanks @user3323
Using your code sample, I can repro this when typescript.useCodeSnippetsOnMethodSuggest is enabled and this has nothing to do with the root cause for #47988

cc @mjbvz

@ramya-rao-a ramya-rao-a changed the title Snippets list becomes frozen Snippets docs becomes frozen when using useCodeSnippetsOnMethodSuggest Apr 24, 2018
@ramya-rao-a ramya-rao-a added the typescript Typescript support issues label Apr 24, 2018
@ramya-rao-a ramya-rao-a modified the milestones: April 2018, May 2018 Apr 26, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented May 25, 2018

@user3323 I dont see this happening anymore. Can you try again from your end? If you still see it, then I can re-open this issue

@mjbvz mjbvz added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label May 25, 2018
@roblourens roblourens removed this from the May 2018 milestone Jun 1, 2018
@roblourens
Copy link
Member

Removing from milestone

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*not-reproducible Issue cannot be reproduced by VS Code Team member as described suggest IntelliSense, Auto Complete typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

4 participants