Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test FileSystemProvider API #48412

Closed
2 tasks done
jrieken opened this issue Apr 23, 2018 · 2 comments
Closed
2 tasks done

Test FileSystemProvider API #48412

jrieken opened this issue Apr 23, 2018 · 2 comments

Comments

@jrieken
Copy link
Member

jrieken commented Apr 23, 2018

Refs: #47475

Complexity: 3

We have new API that allows extensions to contribute a file system, FTP servers and LiveShare are good examples for this.

This item is about the API mostly, think of a review. Have an implementation for trying out things but don't get stuck in the details of your backend. There is another item that is about implementing a file system provider

Please test and think about the following.

  • Is the API using concepts that resonate with you? Does something appear as completely alien?
  • Do the comments make sense?
  • In some places the API uses booleans instead of enums, e.g to express the file type.
  • The API often talks about files which generally means folders, symlinks, and regular files.
  • use the MemFs-sample and check if it meets you expectation of how to implement this API
@jrieken jrieken added this to the April 2018 milestone Apr 23, 2018
@jrieken
Copy link
Member Author

jrieken commented Apr 23, 2018

FYI - to test against the latest API do the following:

  • open your extensions package.json file
  • change the engine.vscode property to *
  • run npm run postinstall (assuming you have the vscode module as dev-dependency)
  • undo the engine-version change from step 2

@alexdima alexdima removed their assignment Apr 24, 2018
@dbaeumer dbaeumer removed their assignment Apr 24, 2018
@dbaeumer
Copy link
Member

Added my comments to #48527

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants