Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert search include/exclude patterns #48433

Closed
NathanDubord opened this issue Apr 23, 2018 · 2 comments
Closed

Revert search include/exclude patterns #48433

NathanDubord opened this issue Apr 23, 2018 · 2 comments
Assignees
Labels
search Search widget and operation issues

Comments

@NathanDubord
Copy link

In the March release the include/exclude patterns in the Search view were combined. With both include/exclude combined in a single box, it's become impossible to see what filters you have applied. I find this especially difficult trying to find the !'s in the box to differentiate between the includes/excludes.
Example:
screen shot 2018-04-23 at 1 48 46 pm

Is there any plan to reinvestigate this? I, along with many team members have resorted to other means when doing more complex searches.

@vscodebot
Copy link

vscodebot bot commented Apr 23, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the search Search widget and operation issues label Apr 23, 2018
@NathanDubord
Copy link
Author

NathanDubord commented Apr 23, 2018

Closing issue, just found the ticket where it was decided this would be reverted.
#46315

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants