Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge editor.largeFileSize and editor.largeFileLineCount #48546

Closed
alexdima opened this issue Apr 24, 2018 · 2 comments
Closed

Merge editor.largeFileSize and editor.largeFileLineCount #48546

alexdima opened this issue Apr 24, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Apr 24, 2018

As @isidorn points out in #44986 (comment), most likely people will want to turn off the limitations, and giving a value is more or less meaningless...

We could have a single setting called editor.largeFileOptimizations and turn it to false. @isidorn any better ideas for the setting name ?

@isidorn
Copy link
Contributor

isidorn commented Apr 24, 2018

I like that setting name, I would in the hover describe the idea and warn the user that changing the default behavior could lead to vscode being unresponsive when opneing large files.

The only issue with that name is that I would not be 100% sure what does true and what does false mean. Is optimisation to allow to fastly open it (default) or to show highlights
I understand as a developer that it is the first, but for hte user might not be so clear.
So I would try to address this in the hover. That optimizations means speedup

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Apr 25, 2018
@alexdima
Copy link
Member Author

There is now a single setting called editor.largeFileOptimizations with the following description: "Special handling for large files to disable certain memory intensive features".

@isidorn isidorn added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants