-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench picks up settings.json file at the top of the workspace #48627
Comments
(Experimental duplicate detection) |
@shizengzhou can you share a screenshot how this looks like for you? |
The error in the log is #48523 @shizengzhou Yes, please share a screenshot. |
git pull
, the file icons disappeared and there is an errorgit pull
, the file icons disappeared
@bpasero Have you seen this before? I don't think this is related to git at all. |
@joaomoreno no this is news to me @shizengzhou can you make sure to reproduce with todays latest insider? |
@bpasero I'm sure to reproduce with todays latest insider. |
@shizengzhou are the icons coming back when you change the icon theme? |
@bpasero VS Code seems to treat the settings.json in the project as my settings.json by mistake. |
@shizengzhou You mean |
@sandy081 There is no |
Yes, file icon theme in the workspace settings is overriding your theme in user settings which is expected. |
@sandy081 But the file is at the root of the workspace, not in |
git pull
, the file icons disappeared
@sandy081 I just hit this too by accident, seems like a regression. |
Also, when that happens, changing a theme causes a |
Yeah.. it is a regression from my refactorings. My relative checks were happening on root folder instead of @shizengzhou Thanks for reporting this. |
Issue Type: Bug
The file icons disappeared and there is an error.
renderer3.log
VS Code version: Code - Insiders 1.23.0-insider (b845ce9, 2018-04-24T05:17:07.677Z)
OS version: Windows_NT x64 10.0.16299
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: unavailable_software
webgl: enabled
webgl2: enabled
Extensions (4)
The text was updated successfully, but these errors were encountered: