Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18N: Fix,Change and union the Chinese translations in different files #48729

Merged
merged 1 commit into from May 10, 2018
Merged

i18N: Fix,Change and union the Chinese translations in different files #48729

merged 1 commit into from May 10, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2018

Change Logs:

  1. Fix: Move the comments into JSON's body to avoid JSON's parsing error
    (i18n/chs/src/vs/base/common/json.i18n.json).

A right example is i18n/chs/src/vs/base/common/errorMessage.i18n.json

  1. Change and Union:

Because this error means you have invalid EOF symbols. It would be better we can translate it more clearly (such as in js or C#, we've missed "}" at the end of code).

What's more, it's NOT so easy and simple to understand what '预期的文件结尾' is (This translation just comes from English words one by one "End Of File" and "Expected", which is hard to understand), what we should do is to notify users what they've missed.

BTW: There are two places having the different translation for "error.endOfFileExpected", so I've unioned them all together in this submit.

  1. i18n/chs/src/vs/base/common/json.i18n.json
  2. i18n/chs/src/vs/base/common/jsonErrorMessages.i18n.json

@msftclas
Copy link

msftclas commented Apr 26, 2018

CLA assistant check
All CLA requirements met.

@dbaeumer dbaeumer assigned danyeh and unassigned dbaeumer Apr 26, 2018
@ghost ghost changed the title Translation from 预期的文件结尾 to 需要文件结尾符EOF Translation from 预期的文件结尾 to 需要文件结尾标识(EOF) May 8, 2018
@ghost ghost changed the title Translation from 预期的文件结尾 to 需要文件结尾标识(EOF) i18N: Fix,Change and union the Chinese translations in different files May 8, 2018
@ghost
Copy link
Author

ghost commented May 8, 2018

@danyeh : I've fixed some issues in the i18N's JSON and update Chinese translations. Please see in details in Change Logs I've updated below.

@danyeh danyeh merged commit f6d4dca into microsoft:master May 10, 2018
@danyeh
Copy link
Contributor

danyeh commented May 10, 2018

Thanks @MaleDong for your feedback! I have merged your change in.
However, any change to localization should be made in Transifex. Plus we are moving to Language Pack as extension model.
Visit https://aka.ms/vscodeloc for information of VS Code community localization program. And language pack extension

@ghost
Copy link
Author

ghost commented May 11, 2018

OK next time I'll submit there:)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants