Update SCSS syntax extension #49076
Merged
Update SCSS syntax extension #49076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aeschli
requested changes
May 4, 2018
extensions/scss/package.json
Outdated
| "version": "1.0.0", | ||
| "publisher": "vscode", | ||
| "engines": { "vscode": "*" }, | ||
| "scripts": { | ||
| "update-grammar": "node ../../build/npm/update-grammar.js atom/language-sass grammars/scss.cson ./syntaxes/scss.tmLanguage.json" | ||
| "update-grammar": "npm run update-scss && npm run update-sassdoc", |
There was a problem hiding this comment.
update-grammar.js can already update multiple grammars from the same file. See https://github.com/Microsoft/vscode/blob/master/extensions/perl/package.json#L9 for the syntax.
There was a problem hiding this comment.
Thanks for the tip — updated the script syntax 👍
stormwarning
force-pushed
the
update-scss-syntax-extension
branch
from
8b47fd6
to
e8bf2a2
Compare
|
@stormwarning Awesome, thanks a lot for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuilds the SCSS syntax from the source repo (https://github.com/atom/language-sass).
The latest version of the syntax includes a separate file for SassDoc comment blocks, so
I've modified the scripts and grammars in
package.jsonto account for that.Closes #49071