Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterised commands should not show up in keybindings overview #4915

Closed
bpasero opened this issue Apr 4, 2016 · 1 comment
Closed

Parameterised commands should not show up in keybindings overview #4915

bpasero opened this issue Apr 4, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Apr 4, 2016

While looking into #58 I noticed that we register commands that require arguments to run. They still show up in the list of unassigned commands in the keybindings list which imho is not good because if you try to run them they cannot work without input. I think we should indicate this to the keybinding service that assigning a keybinding to those does not work.

screen shot 2016-04-04 at 17 25 42

screen shot 2016-04-04 at 17 25 48

@alexandrudima @jrieken fyi

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Apr 4, 2016
@jrieken
Copy link
Member

jrieken commented Apr 4, 2016

yeah... commands starting with an _ should already be filtered. Unsure what to do the others...

@jrieken jrieken self-assigned this Apr 4, 2016
@jrieken jrieken added this to the April 2016 milestone Apr 4, 2016
@jrieken jrieken closed this as completed in 36439ca Apr 6, 2016
@jrieken jrieken assigned bpasero and unassigned jrieken Apr 28, 2016
@bpasero bpasero added the verified Verification succeeded label Apr 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants