Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode.workspace.findFiles() can return no result with certain RIPGREP_CONFIG_PATH #49283

Closed
Fiyorin opened this issue May 5, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded
Milestone

Comments

@Fiyorin
Copy link

Fiyorin commented May 5, 2018

  • VSCode Version: 1.23.0
  • OS Version: Arch Linux

Steps to Reproduce:

  1. set this environment variable (for example inside .bashrc): export RIPGREP_CONFIG_PATH=~/.config/ripgreprc
  2. inside ~/.config/ripgreprc put "--color=always" (without quotes)
  3. create a new test project: $ dotnet new console
  4. launch vscode: $ code .
  5. install the omnisharp c# extension and witness how it doesn't start the omnisharp server.
    it can't launch the server, because it calls "vscode.workspace.findFiles(...)" (it's in omnisharp v.1.14.0 on src/omnisharp/launcher.ts line 48), which doesn't return any results due to the ripgrep configuration from the environment variable. findFiles will simply return an empty array without any results, but it should return one result.

workaround: i put "unset RIPGREP_CONFIG_PATH" inside the launcher of /usr/bin/code

Does this issue occur when all extensions are disabled?: Yes. on the master branch, launch the debug task called "VS Code API Tests (single folder)". the test calling findFiles will fail:
2) workspace-namespace findFiles: AssertionError: 0 == 1

@vscodebot vscodebot bot added the new release label May 5, 2018
@BurntSushi
Copy link

BurntSushi commented May 6, 2018

VS Code probably wants to use ripgrep with the --no-config option, which will prevent ripgrep from reading its configuration from the environment (forever and always).

@roblourens
Copy link
Member

Yes, thanks @BurntSushi

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label May 7, 2018
@roblourens roblourens added this to the April 2018 milestone May 7, 2018
@chrmarti
Copy link
Contributor

chrmarti commented May 7, 2018

Moving to recovery milestone. (I assume that was the intention.)

@vscodebot vscodebot bot removed the new release label May 8, 2018
@roblourens roblourens modified the milestones: May 2018, June 2018 May 30, 2018
@roblourens roblourens added the debt Code quality issues label May 30, 2018
@aeschli aeschli added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants