Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support xterm.js' letterSpacing setting #49566

Closed
Tyriar opened this issue May 9, 2018 · 4 comments
Closed

Support xterm.js' letterSpacing setting #49566

Tyriar opened this issue May 9, 2018 · 4 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented May 9, 2018

terminal.integrated.letterSpacing should support integer (pixel) values
@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels May 9, 2018
@Tyriar Tyriar added this to the May 2018 milestone May 9, 2018
@Tyriar Tyriar self-assigned this May 9, 2018
@Tyriar Tyriar mentioned this issue May 9, 2018
Closed
@Tyriar Tyriar closed this as completed in 33a00fd May 9, 2018
@Tyriar
Copy link
Member Author

Tyriar commented May 9, 2018

@rfgamaral you can test it out in tomorrow's Insiders:

screen shot 2018-05-09 at 10 25 42 am

@rfgamaral
Copy link

rfgamaral commented May 9, 2018 •
edited

Great, awesome job, thanks :)

I know it's a bit unrelated, but hard would it be to implement a similar setting on Hyper.js?

@Tyriar
Copy link
Member Author

Tyriar commented May 10, 2018

@rfgamaral should be pretty easy, you would need to expose the xterm setting and then make sure that sizing still works correctly.

@rfgamaral
Copy link

Thank you :)

@Tyriar Tyriar added the verification-needed Verification of issue is requested label May 26, 2018
@roblourens roblourens added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
3 participants
@rfgamaral @roblourens @Tyriar