Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a grid editor layout feature #49599

Merged
merged 493 commits into from
Jun 2, 2018
Merged

Implement a grid editor layout feature #49599

merged 493 commits into from
Jun 2, 2018

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented May 10, 2018 •
edited

For #14909 and #2755

Current Plan is to make this feature testable for this months (May) endgame week and then ship it to insiders early June. This would mean it lands in stable for the release end of June.

before

@bpasero bpasero added this to the May 2018 milestone May 10, 2018
@bpasero bpasero self-assigned this May 10, 2018
@microsoft microsoft locked and limited conversation to collaborators May 10, 2018
bpasero and others added 26 commits May 11, 2018 09:35
@bpasero
grid - simplify and polish
63118b7
@bpasero
grid - do not allow cross window DND for group when tabs enabled
51242ba
@bpasero
grid - more dnd tweaks
efd80fa
@bpasero
grid - allow to get groups in grid order
5e27190
@bpasero
grid - reduce drop operations a bit
d3082d7
@bpasero
grid - adopt IOpenEditorEvent
540a57e
@bpasero
grid - adopt delegating editor service
cf8014e
@bpasero
grid - still allow copy operation when dropping onto same group
ab3d507
@bpasero
grid - some cleanup
b0cd496
@bpasero
grid - towards GroupIdentifier over Position in IEditor
01bf961
@bpasero
grid - drop editor group label
1e2e8fb
@bpasero
grid - use group identifier in IEditorIdentifier
ebe9654
@bpasero
grid - per group editor view state
61ad210
@bpasero
grid - fix issue with delegating editor service
31e42aa
@bpasero
grid - clarify active/visible text editor control to support diff as …
7919b9d 
…well
@bpasero
grid - some 💄
03f7fe7
@alexr00 @bpasero
Added a setting for configuring open direction for "open to the side" (…
dfb6572 
…#49523)
@bpasero
grid - openSideBySideDirection 💄
0f151ee
@bpasero
grid - add and adopt setInput() cancellation tokens
c0f3c66
@bpasero
Merge branch 'master' into ben/editor
3133cbc
@bpasero
grid - add a way to get a label for a group
7c1d60c
@bpasero
grid - first cut workbench layout adoption
1d5d624
@bpasero
grid - towards a better layout
b171096
@bpasero
grid - introduce some next editor tests
cd127d3
@bpasero
grid - more tests scaffolding
5758340
@bpasero
grid - more tests adoption
46a1c8b
bpasero and others added 28 commits May 31, 2018 15:24
@bpasero
grid - add workbench.action.closeEditorsAndGroup
f50c8e9
@isidorn
open editors: close group action
91d3050 
fixes #50625
@isidorn
open editors: use actionRunner for contexts
1815c1d 
fixes #50621
@joaomoreno
grid: getNeighborViews
30499c2
@bpasero
grid - adopt wrapping
035f2e8
@isidorn
Some menu action clients (ActionBar) handle alternative actions on th…
172309c 
…eir own so the alternative actions should be ignored

fixes #50581
@isidorn
fillInActionBarActions and fillInContextMenuActions for clarity
d90b2db
@joaomoreno
grid: fix neighbor npe issue
3a7a813
@joaomoreno
grid: more getNeighborViews tests
deebe17
@joaomoreno
grid: use boundaries for neighbor finding
a2471ef
@joaomoreno
grid: getNeighborViews perf
c4551b7
@joaomoreno
grid: add todo
a655c72
@bpasero
Merge branch 'master' into ben/editor
6b11235
@bpasero
grid - fix issues with touchbar updating
b70c913
@bpasero
grid - use viewColumnToEditorGroup in more places
ba8c0a8
@bpasero
grid - close all groups should preserve first group
69786b2
@bpasero
grid - assign some default keybindings for focus group
08cacfa
@bpasero
grid - 💄
518e036
@isidorn
fixes #50926
9af426f
@isidorn
show alternative actions when alt is pressed, not only on mouse over
8dc5cec
@isidorn
open editors: click on groups should activate them
b902036
@bpasero
update description (for #50677)
4ead366
@bpasero
grid - tweak some groups access order
0f4cde3
@bpasero
grid - prevent multiple confirmation dialogs for the same editor to s…
bb74d93 
…how up (for #50539)
@bpasero
grid - fix bad === for editors
533dc64
@joaomoreno
💄 grid, cleanup getViews()
0bc81da
@joaomoreno
Merge branch 'master' into grid
9a59948
@bpasero
Merge branch 'master' into ben/editor
1a0ce2c
@bpasero bpasero merged commit d2b6bbb into master Jun 2, 2018
@joaomoreno joaomoreno deleted the ben/editor branch June 28, 2018 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
June 2018
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bpasero @mjbvz @joaomoreno @alexr00 @isidorn