Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow class names to begin with an underscore in textModel.ts #49652

Merged
merged 1 commit into from
May 15, 2018

Conversation

chsienki
Copy link
Contributor

As per microsoft/monaco-editor#869 class names that begin with an underscore are being cleaned of the underscore even though it is a valid identifier.

This stops underscores being cleaned, which allows WebPack generated css classnames to be used as decorations.

@alexdima
Copy link
Member

👍 Thank you!

@alexdima alexdima added this to the May 2018 milestone May 15, 2018
@alexdima alexdima merged commit 686498e into microsoft:master May 15, 2018
@chsienki chsienki deleted the fix_css_classnames branch May 15, 2018 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants