Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt to change language after update #50119

Closed
chrisdias opened this issue May 18, 2018 · 2 comments
Closed

prompt to change language after update #50119

chrisdias opened this issue May 18, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone

Comments

@chrisdias
Copy link
Member

chrisdias commented May 18, 2018

Issue Type: Bug

I have the Hungarian language pack installed but I do not have locale.json set to Hungarian. I must have been testing it at some point, but I was running by default with English strings.

I upgraded to 1.23.1 and on restart I was prompted to change the UI to Hungarian. The language pack may have been upgraded as well, I don't know what the vesion was before I upgraded code itself.

image

VS Code version: Code 1.23.1 (d0182c3, 2018-05-10T17:11:17.614Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i5-2400S CPU @ 2.50GHz (4 x 2494)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 7.98GB (2.17GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (9)
Extension Author (truncated) Version
vscode-opennewinstance chr 0.0.4
tslint eg2 1.0.29
vscode-npm-script eg2 0.3.4
vscode-azureappservice ms- 0.8.1
vscode-language-pack-hu MS- 1.23.2
azure-account ms- 0.4.0
azurecli ms- 0.4.1
vscode-docker Pet 0.0.27
gitblame wad 2.4.2
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) extensions Issues concerning extensions labels May 22, 2018
@sandy081 sandy081 added this to the May 2018 milestone May 22, 2018
@ramya-rao-a
Copy link
Contributor

@sandy081 Am just curious... Was this issue due to the onDidInstallExtension event being fired for not just extension installs but extension updates as well?

@sandy081
Copy link
Member

@ramya-rao-a Yes. Now the event has information about whether it is for install or update.

@chrmarti chrmarti added the verified Verification succeeded label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants