Custom explorer nodes not displaying

[chrisdias]

Issue Type: Bug

One of the nodes in the Docker explorer fails to refresh. In the debugger, i can see the call to getTreeItem() returning the proper data, but the children don't appear. It doesn't happen all the time, but it does happen about 90% of the time. This code has not changed in months and worked earlier, so I believe something changed in Code itself.

To repro:

• Create some azure container registries

  • In the Azure portal, choose Create a Resource on the left side
  • Search for Container Registry
  • Click Create
  • Provide a unique Registry Name, the proper Subscription, Resource Group, etc.
  • Click Create, should only take about 30sec to create the registry, so create a couple more...

• Get the code

git clone https://github.com/microsoft/vscode-docker
cd vscode-docker && npm install
code-insiders .

• F5 to run the extension
• Install the Azure Account extension into the Extension Development Host instance
• Open the command palette, choose Azure: Sign-in and sign into your account
• cmd+p and Reload the Extension Development Host
• Open the Docker view on the Activity Bar
• expand the Registries node
• expand the Azure node

You should see your registries.

• Collapse the Azure node
• Press refresh on the DOCKER: EXPLORER bar
• Expand the Azure node

Result: it should be empty. If it isn't, try the expand/collapse/refresh pattern a few times, or reload the Extnesion Development Host and do it again.

I've set a breakpoint on line 31 of explorer\models\azureRegistryNodes.ts and see it being called, with the appropriate data being returned. But, the children are not loaded.

VS Code version: Code 1.23.1 (d0182c3, 2018-05-10T17:11:17.614Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-2400S CPU @ 2.50GHz (4 x 2494)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: unavailable_software video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	7.98GB (1.73GB free)
Process Argv	C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader	no
VM	0%

Extensions (9)

Extension	Author (truncated)	Version
vscode-opennewinstance	chr	0.0.4
tslint	eg2	1.0.29
vscode-npm-script	eg2	0.3.4
vscode-azureappservice	ms-	0.8.1
vscode-language-pack-hu	MS-	1.23.2
azure-account	ms-	0.4.0
azurecli	ms-	0.4.1
vscode-docker	Pet	0.0.27
gitblame	wad	2.4.2

[sandy081]

@chrisdias Thanks for the steps. Will try to reproduce it and investigate.

[chrisdias]

Tested on latest insiders, everything working as expected. thanks @sandy081 !!!