Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji fonts to default font families #50168

Merged
merged 1 commit into from May 29, 2018
Merged

Conversation

rianadon
Copy link
Contributor

This makes most emoji (like πŸ˜ƒ for example) render correctly in the editor, fixing #32840.

However, it doesn't support zero width joiners, since these glyphs are handled by the normal, non-emoji fonts and don't get rendered by the emoji fonts. Thus emoji like πŸ™‹β€β™‚οΈ still don't render correctly, although most others do.

Also for Linux I only have the Ubuntu emoji font (Noto). If anyone knows which fonts other operating systems use these should get added.

@alexdima
Copy link
Member

πŸ‘

@alexdima alexdima merged commit 43057ae into microsoft:master May 29, 2018
@alexdima alexdima added this to the May 2018 milestone May 29, 2018
alexdima added a commit that referenced this pull request Jun 11, 2018
Revert "Add emoji fonts to default font families"

This reverts commit 88e7535.
alexdima added a commit that referenced this pull request Jun 11, 2018
Revert "Add emoji fonts to default font families"

This reverts commit 88e7535.
@alexdima
Copy link
Member

alexdima commented Jun 11, 2018

This got reverted via 7399f84 and 0f0770d due to #51335

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants