Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CommentProvider, panel, and editor contribution #50501

Merged
merged 228 commits into from
Jun 4, 2018
Merged

Add CommentProvider, panel, and editor contribution #50501

merged 228 commits into from
Jun 4, 2018

Conversation

RMacfarlane
Copy link
Contributor

No description provided.

rebornix and others added 30 commits March 26, 2018 16:31
@rebornix
dynamic height review widget
b4195ab
@mjbvz
Working on adding comment api
094a469
@rebornix
add missing copyright
770587a
@rebornix
Dispose view zone.
f5e216d
@rebornix
remove commits provider
f2ee416
@rebornix
better icon
b1020fb
@rebornix
click should always work
0036c96
@rebornix
Fix build failure
fbd34d3
@rebornix
Format.
785b206
@rebornix
Do not show comments panel when there is no comment.
f7f4f3c
@rebornix
Use octokit/rest.js instead of octokat.
36d3155
@rebornix
configuration for github tokens
a6e471b
@rebornix
remove uncessary code.
82c41c9
@rebornix
move comment analyze to common
1c7c3c9
@rebornix
diff view when the file does not exist in a commit
0671a03
@rebornix
review requested PR.
bc23a02
@rebornix
Mine PRs.
df52ca0
@rebornix
Show comments in problem panel.
b3ef6d4
@rebornix
crazy idea of injecting resource groups into git scm viewlet
211af8c
@rebornix
bad copyright
d3c0f36
@rebornix
fetch PR branch (readonly) and checkout locally
d707e64
@mjbvz
Rename webviewInput to webviewEditorInput
7307023
@mjbvz
Reduce duplicate state for active webviews
7870796
@mjbvz
Make sure we don't try posting mesages to disposed markdown previews
5a0ead5 
Fixes #45553
@rebornix
Gravatar is cool.
082d403
@rebornix
Avoid large function.
b4afa20
@rebornix
Moving common code out of prProvider.
96153d1
@rebornix
typing is always good
54d3602
@rebornix
use 64 bits for user gravatar.
300756d
@mjbvz
Prototype webview widget
d7e0604 
Start prototyping a webview widget. Code is still super rough
rebornix and others added 19 commits May 23, 2018 13:59
@rebornix
fallback to partial diff when the commit does not exist locally.
16214f1
Ensure widgets and file decorations are removed when exiting review mode
d0f6ed7
Remove count badges from comments panel
74bbf79
@rebornix
textarea in iframe keybinding issue.
72d1a4c
@rebornix
show review comments and diffview in description page.
439be25
Fix reloading description webview
ec22a1e
A bit of code cleanup
a96e877
@rebornix
Fix diff line type for diffhunk header.
1d2334e
@rebornix
refactor of tree view nodes.
2c64d63
@rebornix
remove unused code.
429a2da
@rebornix
generic comment icon
b95920f
@rebornix
fix infinite loop patch parsing.
4780fef
@rebornix
empty string is a valid branchName parameter for git fetch.
fb3fbbb
@rebornix
group comments related api in a region and add warning comment.
1834af8
Remove unused code
a1b48a0
Small fix to comment icon calculation
2c0b7e6
Remove git-extended folder
0445060
Revert changes to hygiene file
8b39ee1
Remove erroneous changes from past merges
1c5a196
@rebornix
Copy link
Member

rebornix commented Jun 4, 2018

@bpasero helped merge our code base with master and adopt new grid api, thanks for the great effort! I cherry picked the change from rebornix/review here now it has no conflicts with master branch.

@rebornix
Copy link
Member

rebornix commented Jun 4, 2018

Already moved the comments service into workbench/parts/comments.

@RMacfarlane RMacfarlane merged commit e4f2184 into master Jun 4, 2018
@joaomoreno joaomoreno deleted the rmacfarlane/review branch June 28, 2018 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rebornix rebornix

@RMacfarlane RMacfarlane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RMacfarlane @rebornix @bpasero @mjbvz