Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Editor does not dispose properly #50555

Closed
bpasero opened this issue May 28, 2018 · 0 comments
Closed

Settings Editor does not dispose properly #50555

bpasero opened this issue May 28, 2018 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 28, 2018

I am testing from the ben/editor branch that contains the changes for Grid. If you split an editor to the side and then close that editor, we now actually dispose the editor and no longer keeping it around as we used to before. This means that we now rely on the editor freeing up its resources properly.

For the new settings editor I see lots of controls still hanging around after:

  • open a single settings editor
  • split it once
  • close the second instance
  • create a heap snapshot
  • repeat split/close a couple of times
  • create a heap snapshot again
  • compare it to the first

image

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues workbench-editor-grid Grid layout issues in the editor area labels May 28, 2018
@roblourens roblourens added this to the July 2018 milestone Jun 30, 2018
@mjbvz mjbvz added the verified Verification succeeded label Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

3 participants