Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find and replace dialog: Alt+L to off: Selection lost #50567

Closed
ZtrevorZ opened this issue May 28, 2018 · 2 comments
Closed

Find and replace dialog: Alt+L to off: Selection lost #50567

ZtrevorZ opened this issue May 28, 2018 · 2 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations

Comments

@ZtrevorZ
Copy link

ZtrevorZ commented May 28, 2018 •
edited

When replacing text (control + h to open the find and replace dialog): I would like to toggle "Find in selection" to off with Alt+L but keep my selection. Currently when you have valid "before" and "after" entries in the dialog (as opposed to blanks) and then press Alt+L to "off", the text is deselected and you have to re-select it by hand. Finding only (without replace) seems to work OK ... it is when replacing text that the problem occurs. Thanks!

  • VSCode Version: 1.23.1
  • OS Version: x64 (Windows 10 64bit)
@ZtrevorZ ZtrevorZ changed the title Find and replace Alt+L loses selection Find and replace dialog: Alt+L to off: Selection lost May 28, 2018
@ZtrevorZ ZtrevorZ changed the title Find and replace dialog: Alt+L to off: Selection lost Find and replace dialog: Alt+L to off: Selection lost [feature-request] May 28, 2018
@ZtrevorZ ZtrevorZ changed the title Find and replace dialog: Alt+L to off: Selection lost [feature-request] Find and replace dialog: Alt+L to off: Selection lost May 28, 2018
@alexdima alexdima assigned rebornix and unassigned alexdima May 28, 2018
@alexdima alexdima added the editor-find Editor find operations label May 28, 2018
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Sep 4, 2018
@rebornix rebornix mentioned this issue Sep 13, 2018
Closed
@rebornix rebornix added this to the On Deck milestone Sep 21, 2018
@rebornix
Copy link
Member

@ZtrevorZ based on what I tested on latest Insiders (we made some fixes this month), if we have editor.autoFindInSelection turned on, when we open the find widget with either ctrl+f and ctrl+h after selecting some text, the focus will be in the find input box. Since our find widget does searches incrementally, the moment when you switch off "Find In Selection" , we will research the keyword in the find input box in the whole document, which will finally move the selection to the nearest match.

As I no longer reproduce what you described and our workflow is described as above, I'd like to close it for now.

@rebornix rebornix removed this from the On Deck milestone Sep 24, 2018
@ZtrevorZ
Copy link
Author

Hi @rebornix ... Thank you so much for the reply. That's fine - You can close it! Friendly regards

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebornix @alexdima @ZtrevorZ