Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File watcher fails over Samba share #506

Closed
jmm opened this issue Nov 23, 2015 · 9 comments
Closed

File watcher fails over Samba share #506

jmm opened this issue Nov 23, 2015 · 9 comments
Assignees
Labels
verified Verification succeeded
Milestone

Comments

@jmm
Copy link

jmm commented Nov 23, 2015

The Explore sidebar doesn't always reflect the current state of the file system, e.g. I add a file from outside of vscode and it doesn't appear in Explore. I frequently have the same problem with Atom (which I also have running and which may be consuming all of the watches), but at least in Atom's tree view I can collapse, expand a folder via keyboard commands to get it to refresh. Is there a way to do it in vscode? If not, I pose it as a feature request. Thanks!

@bpasero
Copy link
Member

bpasero commented Nov 24, 2015

@jmm the explorer should always be in sync with the file system, otherwise this indicates a problem with our file watcher. On what OS are you on? And can you reproduce the issue repeatadly?

@jmm
Copy link
Author

jmm commented Nov 24, 2015

@bpasero In this case I saw it while accessing a Samba share running on Linux from vscode 0.10.1 running on Win 7 x64.

And can you reproduce the issue repeatadly?

Not sure yet -- I just tried vscode for the first time recently. And I was getting inexplicably high CPU usage (total usage much higher than the sum of the values in the CPU column in Task Manager) that I think was at least partially attributable to vscode, so I closed it for the time being. I've had nothing but problems with file watching in Atom, so I suspect I'll see this issue again in vscode.

In any case, although it would obviously be good for it to always be in sync, there's a refresh button that I can activate with the mouse to work around when it happens, but I'd like something keyboard activated as well.

@jmm
Copy link
Author

jmm commented Nov 24, 2015

@bpasero Ok, I still had higher CPU usage than I should've after closing vscode, then Atom crashed and I still had high CPU usage. I traced some of it to the Program Compatibility Assistant Service via an svchost.exe instance. With Atom not running I started vscode again and I can repro immediately: open a folder on the Samba share, go to the shell and $ touch newfile and it doesn't show up in Explore. Collapse, expand the subtree doesn't make it appear either. I have to click the Refresh button.

@bpasero
Copy link
Member

bpasero commented Nov 24, 2015

Yeah, our watcher might not work reliably for network shares.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Nov 24, 2015
@bpasero bpasero changed the title Refresh the Explore sidebar via keyboard commands File watcher fails over Samba share Nov 24, 2015
@bpasero bpasero modified the milestone: Backlog Nov 26, 2015
@CronLogic
Copy link

Definitely can reproduce this. Moving folder to non-network share seems to solve any problems.

@Cirych
Copy link

Cirych commented Jan 23, 2016

Folder with source code placed on VM (CentOS) and shared via samba. That remote folder connected to windows as network drive.

New file showed in VSCode's explorer immediately, after created in remote console, on first level (folders root). If it's created on 2nd and deeper levels - just need refresh explorer.

Also problem with IntelliSense and .d.ts files
Example with Angular.
In code I can see error on "angular" word and choose download .d.ts file in pop-up menu. After downloading nothing changes with error. But, if I just open .d.ts file in VSCode - error disappear!
So another time starting VSCode I need to open each .d.ts file to remove errors.
Empty jsconfig.json created in folder, but no changes.

One more problem with downloading .d.ts files. First time I try to download any of them - I'v got error. Second time - some downloaded, some not. If I just visit "typings" folder from VSCode explorer - any file will be downloaded.

Remote - CentOS7, samba with maximum permissions.
Local - Windows Server 2012 (platform=3&osversion=6.3.9600)
VSCode - 0.10.6 (on local machine)

@bpasero
Copy link
Member

bpasero commented Mar 24, 2016

This issue was moved to microsoft/vscode-filewatcher-windows#8

@bpasero bpasero closed this as completed Mar 24, 2016
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2016
@bpasero bpasero added the verified Verification succeeded label Apr 29, 2016
@jmm
Copy link
Author

jmm commented Jun 24, 2016

@bpasero Can you please restore the original title of this issue and reopen it? There are 2 separate logical issues:

  1. Refreshing the explorer pane via keyboard command.
  2. Keeping the explorer automatically in sync with the file system.

Item # 1 is the subject and original title of this GitHub issue, but it was taken over by the other issue. That the explorer should always stay in sync with the file system is a separate issue for the following reasons:

  1. It doesn't.
  2. There's no telling if / when it will. (And there doesn't appear to be any activity on it since March 24 except for adding it to the Backlog milestone.)
  3. There's already a command / control to refresh the explorer for whatever reason (we've already discussed a great one ;) -- problems with syncing). This GitHub issue is about activating it via keyboard instead of pointing device.

Thanks!

@bpasero
Copy link
Member

bpasero commented Jun 25, 2016

@jmm try workbench.files.action.refreshFilesExplorer from our insiders build (http://code.visualstudio.com/Download#insiders)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants