Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The interface overview should show a terminal hint #50775

Closed
egamma opened this issue May 30, 2018 · 2 comments
Closed

The interface overview should show a terminal hint #50775

egamma opened this issue May 30, 2018 · 2 comments
Assignees
@chrmarti
Labels
feature-request Request for new features or functionality verified Verification succeeded workbench-welcome Welcome page issues
Milestone
July 2018

Comments

@egamma
Copy link
Member

egamma commented May 30, 2018 •
edited

The interface overview doesn´t show the terminal. I suggest to also show a hint to open the integrated terminal.

image

// fyi @chrisdias @seanmcbreen
@chrmarti chrmarti added this to the June 2018 milestone May 30, 2018
@chrmarti chrmarti added feature-request Request for new features or functionality workbench-welcome Welcome page issues labels May 30, 2018
@chrmarti chrmarti mentioned this issue Jun 15, 2018
Closed
@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2018 •
edited

A fake terminal, actually opening a terminal might be a bad idea as on Windows a notification will pop up and on some environments the terminal will immediately close (like if a sysadmin sets $SHELL to /bin/false. There's no way of detecting if it will fail ahead of time.

@chrmarti chrmarti modified the milestones: June 2018, July 2018 Jun 27, 2018
@chrmarti
Copy link
Contributor

Adding a hint (no fake terminal for now).

@sbatten sbatten added the verification-needed Verification of issue is requested label Aug 1, 2018
@gregvanl gregvanl added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Aug 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
feature-request Request for new features or functionality verified Verification succeeded workbench-welcome Welcome page issues
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
5 participants
@egamma @Tyriar @sbatten @chrmarti @gregvanl