Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4746: adjusted the send a tweet's maximum character limit to accomodate hashtags and via @code. #5116

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

eklavyamirani
Copy link
Contributor

Modified the IFeedback service to provide the character limit that the feedback service supports.
Implemented this logic in TwitterFeedbackService to give the remaining characters after accommodating hashtags (modified to be an array now) and the VIA tag, if one exists.

Fixes #4746

@msftclas
Copy link

msftclas commented Apr 9, 2016

Hi @eklavyamirani, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@eklavyamirani eklavyamirani changed the title issue #4746: adjusted the send a tweet's maximum character limit to accomodate hashtags and via @code. #4746: adjusted the send a tweet's maximum character limit to accomodate hashtags and via @code. Apr 9, 2016
@msftclas
Copy link

msftclas commented Apr 9, 2016

@eklavyamirani, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@joaomoreno joaomoreno merged commit 3e7a204 into microsoft:master Apr 11, 2016
@joaomoreno
Copy link
Member

Thanks! 👍

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send a Tweet reports bad maximum length
3 participants