Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut popup does not read out the message #52025

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 15, 2018 · 2 comments
Closed
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10

Additional Details:
Screenreader,NVDA[2018.2],MAS1.3.1

Repro Steps:
1.Launch VS Code while NVDA is ON.
2.Navigate to Settings icon in Activity Bar->Press Enter->Select "Keyboard Shortcuts" from dropdown.
3.Select any row and navigate to edit button and click on it.
4.Observed that screenreader is not reading the data present in the popup.

Actual:
NVDA is not reading the popup data "Pree desired key combination and then press Enter"
here NVDA is reading it as "code: AltLeft, keyCode: 18, key: Alt => UI: Alt+, user settings: alt+, dispatch: null edit blank"

Expected:
NVDA should reads the popup data.Here NVDA should reads "Pree desired key combination and then press Enter".

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
User will not understand what action have to performed.

MAS Reference:
MAS1.3.1- https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference:
[Accessibility]A11y_VSCode_KeyboardShortcuts_ScreenReader.pptx
Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jun 15, 2018
@RMacfarlane RMacfarlane added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues keybindings-editor Keybinding editor issues and removed editor editor-contrib Editor collection of extras labels Jun 15, 2018
@sandy081 sandy081 modified the milestones: June 2018, July 2018 Jun 18, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_KeyboardShortcuts_ScreenReader: NVDA is not reading "Popup" which appeared after clicking on edit button Keyboard shortcut popup does not read out the message Jul 4, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

This feels like law hanging fruit, the keyboard popup should simply read out the title text. Leaving to July

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jul 16, 2018
@mjbvz mjbvz added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 20, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

6 participants